Skip to content

Conversation

@ultmaster
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings October 22, 2025 11:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI workflows to use a group subscription for Azure API credentials. The changes enable workflows to be triggered by a new "ci-all" label and migrate all Azure API credential references from individual secrets to group subscription secrets.

  • Added support for "ci-all" label to trigger workflows
  • Updated Azure API credential references across all workflow files to use group subscription secrets

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/trigger_on_label.js Added logic to trigger workflows when "ci-all" label is present
.github/workflows/tests-full.yml Updated Azure API credentials to use group subscription secrets
.github/workflows/examples-spider.yml Updated Azure API credentials to use group subscription secrets
.github/workflows/examples-compat.yml Updated Azure API credentials to use group subscription secrets
.github/workflows/examples-calc-x.yml Updated Azure API credentials to use group subscription secrets
.github/workflows/examples-apo.yml Updated Azure API credentials to use group subscription secrets

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

core.notice(
`Triggering this workflow because pull request has the '${labelName}' label.`
);
} else if (labels.includes("ci-all")) {
Copy link

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded label 'ci-all' introduces duplication and reduces maintainability. Consider accepting this as a parameter or constant to maintain consistency with the existing labelName pattern used in the first condition.

Copilot uses AI. Check for mistakes.
@ultmaster ultmaster closed this Oct 22, 2025
@ultmaster ultmaster reopened this Oct 22, 2025
@ultmaster ultmaster merged commit 8abe85a into main Oct 22, 2025
41 checks passed
@ultmaster ultmaster deleted the azure-group-subscription branch October 28, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants